Skip to content

feat(bigframes): update ai.score to match its SQL version#16919

Merged
sycai merged 3 commits intomainfrom
sycai_ai_score_update
May 5, 2026
Merged

feat(bigframes): update ai.score to match its SQL version#16919
sycai merged 3 commits intomainfrom
sycai_ai_score_update

Conversation

@sycai
Copy link
Copy Markdown
Contributor

@sycai sycai commented May 1, 2026

No description provided.

@sycai sycai requested review from a team as code owners May 1, 2026 23:25
@sycai sycai requested review from GarrettWu and TrevorBergeron and removed request for a team May 1, 2026 23:25
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds endpoint and max_error_ratio parameters to the score function and the AIScore operation, enabling more granular control over model selection and error handling. The changes include updates to the Ibis compiler, operation definitions, and documentation, along with new unit tests. Review feedback identifies a case inconsistency in the docstring and an incorrect type hint for the dtype attribute in the AIScore class.

Comment thread packages/bigframes/bigframes/bigquery/_operations/ai.py Outdated
Comment thread packages/bigframes/third_party/bigframes_vendored/ibis/expr/operations/ai_ops.py Outdated
@parthea
Copy link
Copy Markdown
Contributor

parthea commented May 4, 2026

Switching to draft until presubmits are green

@parthea parthea marked this pull request as draft May 4, 2026 15:01
@sycai sycai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2026
@sycai sycai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2026
@sycai sycai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2026
@sycai sycai force-pushed the sycai_ai_score_update branch from fd1b9ac to e8b161e Compare May 4, 2026 20:36
@sycai sycai marked this pull request as ready for review May 4, 2026 21:28
@sycai sycai requested review from a team as code owners May 5, 2026 17:40
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented May 5, 2026

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@sycai sycai force-pushed the sycai_ai_score_update branch from 41d5df0 to 6b84dfc Compare May 5, 2026 17:44
@sycai sycai removed request for a team May 5, 2026 17:45
sycai and others added 3 commits May 5, 2026 17:49
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…erations/ai_ops.py

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@sycai sycai force-pushed the sycai_ai_score_update branch from 6b84dfc to 819cdfe Compare May 5, 2026 17:52
@sycai sycai merged commit 9f42fe1 into main May 5, 2026
30 checks passed
@sycai sycai deleted the sycai_ai_score_update branch May 5, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants